Skip to content

twoliter: add version transition check to check-migrations #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

twoliter: add version transition check to check-migrations #598

wants to merge 1 commit into from

Conversation

@koooosh
Copy link
Contributor

@koooosh koooosh commented Nov 12, 2025

Issue number:

N/A

Description of changes:

Updating the check-migrations task with another test validating all version transitions are present in Release.toml.

Testing done:

Built custom twoliter binary and ran check which resulted in the expected failure:

$ cargo make -e=TWOLITER_ALLOW_SOURCE_INSTALL=false -e=TWOLITER_ALLOW_BINARY_INSTALL=false -e=TWOLITER_SKIP_VERSION_CHECK=true   check
...
[cargo-make][1] INFO - Running Task: check-migrations
Found 1 problem(s) with data store migrations:
    - Missing version transition: (1.47.0, 1.48.0)
Error while executing command, exit code: 1
Error: Command was unsuccessful, exit code 105
Error while executing command, exit code: 1

After fix in Release.toml:

[cargo-make][1] INFO - Running Task: check-migrations
[cargo-make][1] INFO - Build Done in 6.53 seconds.
[cargo-make] INFO - Build Done in 10.85 seconds.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@koooosh koooosh mentioned this pull request Nov 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigh-m vigh-m vigh-m approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koooosh @vigh-m